Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various warnings which become fatal in later versions #1268

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix various warnings which become fatal in later versions #1268

merged 1 commit into from
Nov 4, 2022

Conversation

bzfbd
Copy link

@bzfbd bzfbd commented Nov 4, 2022

  • we cannot use partial initialisation of structs in C++ files (copied from example C files initially it seems)
  • IRAM_ATTR uses a COUNTER, do not use the attribute on the implementation
  • provide missing copy implementations for Rgb and Hsv
  • one no longer can |= on volatile variables; use = | instead
  • fix project and header includes
  • avoid redefining BLINK_GPIO
  • Remove defined but unused variables
  • Fix printf formats (not sure why they change in 5.x)
  • Add missing case statement for 5.x (HTTP_EVENT_REDIRECT)
  • RMT needs to be updated to new interface (CONFIG_RMT_SUPPRESS_DEPRECATE_WARN is on currently; see https://docs.espressif.com/projects/esp-idf/en/release-v5.0/esp32/api-reference/peripherals/rmt.html)
  • Adjust tcpip_adpater_* to esp_netif_*
  • Use buffered versions of ntoa functions for IPv4 addresses and not a static on the stack (also fixes warnings)
  • Whatever I missed

Fix various warnings which become fatal with later gcc versons in esp…
9cedcc4 
…-idf 5.x

- we cannot use partial initialisation of structs in C++ files (copied from example C files initially it seems)
- IRAM_ATTR uses a COUNTER, do not use the attribute on the implementation
- provide missing copy implementations for Rgb and Hsv
- one no longer can |= on volatile variables; use = | instead
- fix project and header includes
- avoid redefining BLINK_GPIO
- Remove defined but unused variables
- Fix printf formats
- Add missing case statement (HTTP_EVENT_REDIRECT)
- RMT needs to be updated to new interface (CONFIG_RMT_SUPPRESS_DEPRECATE_WARN is on currently; see https://docs.espressif.com/projects/esp-idf/en/release-v5.0/esp32/api-reference/peripherals/rmt.html)
- Adjust tcpip_adpater_* to esp_netif_*
- Use buffered versions of *ntoa* functions for IPv4 addresses and not a static on the stack (also fixes warnings)
- Whatever I missed
@jomjol jomjol merged commit 235861e into jomjol:rolling Nov 4, 2022
@jomjol
Copy link
Owner

jomjol commented Nov 4, 2022

sorry, need to revert the commit.
The system is not stable anymore (reboot during MQTT). Can you commit the changes in smaller parts? Changing 25 files is hard to debug, if it is not working.

jomjol pushed a commit that referenced this pull request Nov 4, 2022
@caco3 @jomjol
Revert "System instable"
1d9ef7e 
This reverts commit cb84074.

Cleanup REST API (#1255)

* Replaced URIs:
- value.html => value
- statusflow.html => statusflow
- cputemp.html => cputemp
- rssi.html => rssi
- statusflow.html => statusflow

Removed URLs:
 - wasserzaehler.html

* keep legacy API

* .

* .

* .

* .

* .

* .

* updated links

Remove ErrorMessage

Fix various warnings which become fatal with later gcc versons in esp-idf 5.x (#1268)

- we cannot use partial initialisation of structs in C++ files (copied from example C files initially it seems)
- IRAM_ATTR uses a COUNTER, do not use the attribute on the implementation
- provide missing copy implementations for Rgb and Hsv
- one no longer can |= on volatile variables; use = | instead
- fix project and header includes
- avoid redefining BLINK_GPIO
- Remove defined but unused variables
- Fix printf formats
- Add missing case statement (HTTP_EVENT_REDIRECT)
- RMT needs to be updated to new interface (CONFIG_RMT_SUPPRESS_DEPRECATE_WARN is on currently; see https://docs.espressif.com/projects/esp-idf/en/release-v5.0/esp32/api-reference/peripherals/rmt.html)
- Adjust tcpip_adpater_* to esp_netif_*
- Use buffered versions of *ntoa* functions for IPv4 addresses and not a static on the stack (also fixes warnings)
- Whatever I missed

Correct spelling of "Hostname" (#1270)

Correct sdkonfig

Increase max handler due to new handlers

Revert "Cleanup REST API (#1255)"

This reverts commit f3e73ec.

Revert "Increase max handler due to new handlers"

This reverts commit cbd63ad.

System instable

Revert "Revert "Cleanup REST API (#1255)""

This reverts commit 2793c76.

Co-Authored-By: Bjoern A. Zeeb <patch@zabbadoz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzfbd @jomjol