Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for securing wlan.ini #1509

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Fix for securing wlan.ini #1509

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6813817
Fix for securing wlan.ini
Dec 7, 2022
45ee1ec
Fixing error with ' instead of "
Dec 7, 2022
68180a8
Changing to errorcode 403
Dec 7, 2022
5657127
maybe strcmp instead of regular ==
Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions code/components/jomjol_fileserver_ota/server_file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,12 @@ static esp_err_t delete_post_handler(httpd_req_t *req)
return ESP_FAIL;
}

if (strcmp(filename, "wlan.ini") == 0) {
ESP_LOGE(TAG, "Trying to delete protected file : %s", filename);
httpd_resp_send_err(req, HTTPD_403_FORBIDDEN, "Not allowed to delete wlan.ini");
return ESP_FAIL;
}

if (stat(filepath, &file_stat) == -1) {
ESP_LOGE(TAG, "File does not exist : %s", filename);
/* Respond with 400 Bad Request */
Expand Down