-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced camera functionality #2885
Conversation
@jasaw I added all the new parameters to the config page. Just go to https://github.com/jomjol/AI-on-the-edge-device/actions?query=branch%3Afeature%2Fcrop_image and open the most top build. Then scroll down and use the AI-on-the-edge-device__update__* file for an OTA update. |
@caco3 I found a few issues from my initial testing.
Other than that, crop image feature appears to be working as expected. Btw, I like the improved interface that you've done here. |
I saw this as well, it is already fixed in rolling
Thanks, fixed
Thanks, I missed some, fixed
Thanks, I then will merge it. |
@jasaw Do you know if with this PR by default (Reference image never saved, thus using the defaults of the firmware) there is a difference in the image quality? There seem to be complains that the images are more blurry, but on my tests I do not see this change. See #2901 Could it be that the "sharpness" parameter has an impact? |
Original Pull Request: #2799, core functionality contributed by @jasaw
Features:
All these features are done by the camera itself, so no impact on memory usage or performance of the ESP32.
Discussion here: #2733
This PR also enhances the configuration page and the Reference Image page.
This is my test setup where the camera is taking 1600x1200 and cropping 640x480 out of it.