Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Footer with social links #3311 #3361

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Better Footer with social links #3311 #3361

merged 9 commits into from
Dec 4, 2024

Conversation

SURYANSH-RAI
Copy link
Contributor

Updated the followings

  1. added footer on webpage with social links as suggested in Better Footer with social links can be implemented  #3311
  2. added images related to social links in images folder
  3. updated Readme.md:-
    -> centred the heading for a more soothing look
    -> added table of contents with link for better navigation on page
    -> updated UI related things like managing spaces between lines, and updating appearance of "impressions" content
    -> added a link of your mail in support section
  4. deleted mail.jpg as now a link to mail is there
  5. Note:- the link for donations was taken from Readme.md and no changes in that link is there

@caco3 caco3 marked this pull request as draft October 28, 2024 21:56
@SURYANSH-RAI SURYANSH-RAI marked this pull request as ready for review October 29, 2024 04:21
@jomjol
Copy link
Owner

jomjol commented Nov 1, 2024

@SURYANSH-RAI Thanks for the updates. I'm fine with them beside one change: change my email from an image to a direct link.

I use a picture by purpose, so that e.g. robots do not screen my mail diretly. If somebode wants to contact me, he still needs to type it. So if you could remove that from the footer and the readme.md, I'm fine with the changes.

@SURYANSH-RAI
Copy link
Contributor Author

@jomjol Sure i will do that. That will be a pleasure of mine.

@caco3 caco3 marked this pull request as draft November 11, 2024 20:19
@caco3
Copy link
Collaborator

caco3 commented Dec 1, 2024

@SURYANSH-RAI It looks like as if you didn't yet change it.

@SURYANSH-RAI
Copy link
Contributor Author

Sorry Brother, there were some exams of mine. Surely i will update it today only.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sd-card/html/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@caco3 caco3 marked this pull request as ready for review December 4, 2024 22:33
@caco3 caco3 merged commit 3868cf9 into jomjol:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants