Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure API route get_latest_patient_encounter_by_rfid #135

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

MadelaineJ
Copy link
Collaborator

Problem

  • get_latest_patient_encounter_by_rfid exposes plaintext rfid in request and return

Solution

  • plaintext rfid is now passed via the request body
  • Patient encounter response no longer has rfid included
  • modified tests accordingly
  • note: sanctuary's route should be fixed as well

Ticket URL
https://mediform.atlassian.net/browse/MEDI-61

Documentation
NA

Tests Run
make testapi

Problem
- get_latest_patient_encounter_by_rfid exposes plaintext rfid

Solution
- plaintext rfid is now passed via the request body
- Patient encounter response no longer has rfid included
- note: if sanctuary's route should be fixed as well

Ticket URL
https://mediform.atlassian.net/browse/MEDI-61

Documentation
NA

Tests Run
make testapi
Copy link
Collaborator

@critch646 critch646 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MadelaineJ MadelaineJ merged commit 844c74e into main Mar 22, 2024
1 check passed
@MadelaineJ MadelaineJ deleted the madelaine-sanctuary branch March 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants