Skip to content

Commit

Permalink
[Impeller] no-op fragment program on Android until it works. (flutter…
Browse files Browse the repository at this point in the history
…#43657)

The framework has switched into mat3 by default, which means the fragment program ink sparkle has replaced the default ink splash. Since this is not implemented, all of the impeller benchmarks are crashign.

No-op this so we at least get benchmark numbers until its implemented.
  • Loading branch information
jonahwilliams committed Jul 27, 2023
1 parent e14db68 commit 97c1a4a
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions impeller/entity/contents/runtime_effect_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ bool RuntimeEffectContents::CanInheritOpacity(const Entity& entity) const {
bool RuntimeEffectContents::Render(const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
// TODO(jonahwilliams): FragmentProgram API is not fully wired up on Android.
// Disable until this is complete so that integration tests and benchmarks can
// run m3 applications.
#ifdef FML_OS_ANDROID
return true;
#endif

auto context = renderer.GetContext();
auto library = context->GetShaderLibrary();

Expand Down

0 comments on commit 97c1a4a

Please sign in to comment.