Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS v1.2 for KitKat (and below?) #345

Open
goldfndr opened this issue Feb 23, 2018 · 4 comments
Open

TLS v1.2 for KitKat (and below?) #345

goldfndr opened this issue Feb 23, 2018 · 4 comments

Comments

@goldfndr
Copy link

goldfndr commented Feb 23, 2018

With GitHub having removed support for TLS v1.0 and v1.1, ForkHub no longer works, it gives an error toast (Loading account & organizations failed).

https://stackoverflow.com/questions/28943660/how-to-enable-tls-1-2-support-in-an-android-application-running-on-android-4-1 shows how to enable TLS v1.2 support for pre-Lollipop. There must be something working, since I can access GitHub on both Chrome Mobile and Lightning Browser.

In the meantime, if anyone can direct me to how to get the "News" look for an arbitrary repo via web browser, I'd appreciate it. The closest I can find is Insights, but that doesn't list individual comments.

@ghost
Copy link

ghost commented Feb 24, 2018

square/okhttp#2372 may be instructive here.

@truedat101
Copy link

Noting also, this affects the version of Forkhub found in the Blackberry World App store, which is an Android app, I think maybe v1.2.0 (tagged release of apk), and the Android runtime provided in BB10 is 4.x era. It was a sad day when I opened the app and found that I couldn't get in. I will give a compliment, and say this is THE best performing Android app in terms of speed that I've found on the Blackberry BB10 platform.

@truedat101
Copy link

I'm willing to dig in here and help find a work around, maybe submit a pull request, since I don't have the option to upgrade my Android runtime, and find Forkhub to be essential to my daily work and my ability to be away from my desk but deal with the number of projects and companies I work with that have their stuff on GH.

@truedat101
Copy link

I'll spend some time looking through the referenced okhttp issue, as there seem to be 15 other projects depending on okhttp who are committed to support Android < 5.x, and have provided solutions. Since the problem affect 4.x-4.4 and since the min api version has been bumped to 19 for this app, to continue to maintain backward compatibility is a train that has already left the station. At the very least, this can get fixed for KitKat, and I will make a fork that is off the older code (unless the bump of minsdkversion to api 19 was done for cosmetic reasons ... it was on 8 up to the 1.2.2 tag). In any case, I'd like to fix this for myself also, I'm stuck on api 18. Will dig into this during the upcoming week.

truedat101 added a commit to RazortoothRTC/ForkHub that referenced this issue Nov 9, 2018
Also tackle legacy device support, downgrade minSdkVersion to 18 from 19
unless someone can tell me that there is a reason the code base must be
on API 19.  Note: I've been working at this to be able to continue to
maintain at least one Github client working with BB10 (Blackberry OS10),
which has ForkHub as its sole Github client in the app store
BlackberryWorld (also in Amazon store), however this app stopped working
about a year or so back, and this should provide a fix.  Work with
upstream maintainers to sort out cleanest fix as this only takes into
account a build specific to the legacy devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants