Unaligned read of MIDIPacket::length triggers UB check in recent Rust
#17
Comments
jonas-k
pushed a commit
that referenced
this issue
Jun 11, 2024
This should fix #17. It also simplifies MIDIEventPacketNext, which doesn't need the platform-specific distinction, as the size is 4-byte aligned anyways (see also https://github.com/phracker/MacOSX-SDKs/blob/041600eda65c6a668f66cb7d56b7d1da3e8bcc93/MacOSX11.3.sdk/System/Library/Frameworks/CoreMIDI.framework/Versions/A/Headers/MIDIServices.h#L2387).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See chris-zen/coremidi#49.
Because
MIDIPackets are unaligned on non-ARM platforms, accesing theirlengthandtimeStampfields must happen throughread_unaligned. But this is not needed (and would produce worse machine code) on ARM.These checks have been added in Rust 1.70 (https://releases.rs/docs/1.70.0/, rust-lang/rust#98112).
The text was updated successfully, but these errors were encountered: