Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tig does not maximize after search #845

Closed
Perlence opened this issue Jun 27, 2018 · 6 comments
Closed

Tig does not maximize after search #845

Perlence opened this issue Jun 27, 2018 · 6 comments

Comments

@Perlence
Copy link

Perlence commented Jun 27, 2018 •
edited
Loading

Tig stops resizing correctly after search. Here's a video https://youtu.be/001uQ35RYKI
I built tig on Debian 9.4. It happened to me both on TERM=xterm-256color and TERM=tmux-256color. Apparently this started happening after f21329e.
@koutcher
Copy link
Collaborator

koutcher commented Jun 28, 2018 •
edited
Loading

The problem is not actually linked to the search function (any command you type will cause the same issue). As you point out, readline is in cause. This can be confirmed by using --without-readline option when compiling tig.

Using https://github.com/ulfalizer/readline-and-ncurses, I managed to fix it. I'll send a PR soon.
The fix sounded too easy, it only worked because I forgot to rerun configure after disabling readline :-)

@Perlence
Copy link
Author

Thank you for investigating! Hm, running ./configure --without-readline still leaves readline in config.h, so I had to comment it out manually. Well, I personally can live without readline, since the bug is much more annoying than being unable to use search history.

@koutcher
Copy link
Collaborator

koutcher commented Jun 28, 2018 •
edited
Loading

You also have to remove readline from config.make to avoid linking with libreadline.so

@Perlence
Copy link
Author

Thanks, it's good to know!

koutcher added a commit to koutcher/tig that referenced this issue Jun 29, 2018
@koutcher
Honour configure --without-readline when compiling in Linux or Homebrew
57c6139 
This will allow to work around jonas#845 until a proper fix is found.
koutcher added a commit to koutcher/tig that referenced this issue Jun 29, 2018
@koutcher
Honour configure --without-readline
91ef166 
This will allow to work around jonas#845 until a proper fix is found.
koutcher added a commit to koutcher/tig that referenced this issue Jun 29, 2018
@koutcher
Fix resize not working after entering command (jonas#845)
8542df2
koutcher added a commit to koutcher/tig that referenced this issue Jun 29, 2018
@koutcher
Fix resize not working after entering command (jonas#845)
a8f2a31
koutcher added a commit to koutcher/tig that referenced this issue Jun 29, 2018
@koutcher
Fix resize not working after entering command (jonas#845)
ce43023 
Mininum Readline version is now 6.3 due to the use of the
rl_change_environment variable.

Also fixed check against major required version and added support for
configure --without-readline.
koutcher added a commit to koutcher/tig that referenced this issue Jul 4, 2018
@koutcher
Fix resize not working after entering command (jonas#845)
344849e 
Mininum Readline version is now 6.3 due to the use of the
rl_change_environment variable.

Also fixed check against major required version and added support for
configure --without-readline.
jonas pushed a commit that referenced this issue Jul 7, 2018
@koutcher @jonas
Fix resize not working after entering command (#845) (#846)
64d9c95 
Minimum Readline version is now 6.3 due to the use of the
rl_change_environment variable.

Also fixed check against major required version and added support for
configure --without-readline.
@jonas
Copy link
Owner

jonas commented Jul 8, 2018

Fixed in #846

@jonas jonas closed this as completed Jul 8, 2018
@Perlence
Copy link
Author

Perlence commented Jul 8, 2018

Good job y'all, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas @Perlence @koutcher