Handle undefined __git_complete #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses jonas#1011 As identified in jonas#1011 (comment), there are cases where `__git_complete` is undefined because it is loaded dynamically by bash_completions. As suggested in jonas#1011 (comment), using `pkg-config` to find `git-completion` script, which defines `__git_complete`. And using approach similar to https://github.com/felipec/git-completion/blob/master/git-completion.zsh#L28-L49
rohieb
reviewed
Dec 8, 2020
contrib/tig-completion.bash
Outdated
| #tig-completion requires __git_complete | ||
| #* If not defined, source git completions script so __git_complete is available | ||
| if ! declare -f __git_complete &>/dev/null; then | ||
| _bash_completion=$(pkg-config --variable=completionsdir bash-completion 2>/dev/null) || |
There was a problem hiding this comment.
Nitpick: the indentation should be consistent with the rest of the file.
There was a problem hiding this comment.
Thank you. I will fix that.
…trailing whitespace
|
Yep, LGTM now. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1011
As identified in #1011 (comment), there are cases where
__git_completeis undefined because it is loaded dynamically by bash_completions.As suggested in #1011 (comment), using
pkg-configto findgit-completionscript, which defines__git_complete. And using approach similar to https://github.com/felipec/git-completion/blob/master/git-completion.zsh#L28-L49