Update %(text) when navigating diff contents #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koutcher
reviewed
Feb 10, 2021
src/diff.c
Outdated
| } | ||
| pager_select(view, line); |
There was a problem hiding this comment.
And why not 2 levels up ?
string_ncopy(view->ref, view->ops->id, strlen(view->ops->id));
}
}
pager_select(view, line);
}
There was a problem hiding this comment.
It looks more in line with the documentation (The text of the currently selected line.) and I don't see any drawback to do it for all lines.
There was a problem hiding this comment.
Yep, that seems more logical. No reason to leave out the stat-lines.
f1302c0 added %(text) only in the pager view, and now we add it to the diff and stage views. There are still some other views that don't have it, but that's not a bad thing IMO.
For example, in the main view this seems mostly redundant because the user can compose the line with other substitutions already.
Previously we'd only update %(text) in the header of the diff view. Also update %(text) when inside the diff contents. This allows to determine if the current line is added, deleted or context, which allows to give precise location information when talking to the GitLab API for example.
krobelus
force-pushed
the
update-text-inside-diff
branch
from
6db4cfa to
3ae811f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd only update %(text) in the header of the diff view. Also
update %(text) when inside the diff contents. This allows to determine if
the current line is added, deleted or context, which allows to give precise
location information when talking to the GitLab API for example.