Fix :goto <tag>
#1178
Merged
Fix :goto <tag>
#1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
reviewed
Jan 22, 2022
src/prompt.c
Outdated
| char dest[SIZEOF_STR]; | ||
|
|
||
| snprintf(dest, SIZEOF_STR, "%s^{}", argv[1]); | ||
| goto_id(view, dest, true, true); |
There was a problem hiding this comment.
Thanks for the review Johannes. As one can also just do :<sha1> at the prompt, I'll amend the PR to move the code directly in goto_id().
koutcher
force-pushed
the
fix-goto-tag
branch
3 times, most recently
from
9b0a664 to
278acab
Compare
krobelus
reviewed
Jan 23, 2022
Dereference goto argument to make sure we try to reach the commit and not the tag object for annotated tags. Reviewed-by: Johannes Altmanninger <aclopte@gmail.com>
Yep that definitely looks like a typo. I didn't think of using clang-query before, it's so easy: If the comma operator is too subtle here, we can also be more explicit about ignoring the return value with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereference goto argument to make sure we try to reach the commit and
not the tag object for annotated tags.