Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refdb: ignore prefetch refs #1318

Closed
wants to merge 3 commits into from
Closed

Conversation

arbrauns
Copy link
Contributor

@arbrauns arbrauns commented Mar 4, 2024

These are created by git maintentance and are special-cased in git tools to not be shown, since they are mostly noise.

@arbrauns arbrauns force-pushed the hide-prefetch-refs branch 2 times, most recently from e9be6cc to cd54f43 Compare March 4, 2024 14:41
@Gerschtli
Copy link

@arbrauns Do you know a workaround for that issue other than using your forked version?

@arbrauns
Copy link
Contributor Author

No, I'm not aware of any existing filtering that could be used for this.

@koutcher
Copy link
Collaborator

With Tig >= 2.5.5, add a line set reference-format = hide:other to your .tigrc.

Copy link
Collaborator

@koutcher koutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the code part is OK but the documentation can't be merged as is.

NEWS.adoc Outdated
@@ -12,6 +12,8 @@ Improvements:
- Use HTTPS for GitHub clone URLs. (#1310)
- Move default log view options to tigrc.
- Allow to go to stage view without Enter. (#1284)
- Add new "prefetch" reference type for refs created by `git maintentance`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

doc/tigrc.5.adoc Outdated
- If no format is specified for `tracked-remote`, the format for `remote`
is used.
- If no format is specified for any other reference type, the format for
`branch` is used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the layout of the generated man page. Separating list in asciidoc while staying in the same block doesn't look straightforward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get it to work with the legacy https://pypi.org/project/asciidoc/ either, but asciidoctor can handle it - switching the man pages to that is probably a more complicated endeavour though. I've reverted it back to the running text style.

These are created by `git maintentance` and are special-cased in git
tools to not be shown, since they are mostly noise.
@arbrauns arbrauns force-pushed the hide-prefetch-refs branch from cd54f43 to 3320e30 Compare March 21, 2024 09:14
@arbrauns arbrauns requested a review from koutcher March 21, 2024 09:14
koutcher pushed a commit that referenced this pull request Mar 28, 2024
* refdb: add prefetch reference type

* tigrc: document fallback for reference-format

* tigrc: hide prefetch references by default

These are created by `git maintenance` and are special-cased in git
tools to not be shown, since they are mostly noise.
@koutcher koutcher closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants