Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on GNU sed newline handling in test suite #614

Closed

Conversation

rolandwalker
Copy link
Contributor

The issue is that POSIX sed always fills in a trailing newline, whereas GNU sed maintains the input more faithfully.

This is a small file and it seems just as easy to write it with a literal printf.

After #609 this will be sufficient for the test suite to run on OS X and likely any BSD derivative.

@rolandwalker
Copy link
Contributor Author

Note: this will fail tests without quoting of $@ from #609 .

@jonas jonas closed this in 7e43f26 Jun 23, 2017
@jonas
Copy link
Owner

jonas commented Jun 23, 2017

Thanks I squashed this into the #609 PR

@rolandwalker rolandwalker deleted the rm-gnuism-stage-split-chunk branch June 23, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants