Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special call to clear the status window after user input #650

Closed
wants to merge 1 commit into from

Conversation

jonas
Copy link
Owner

@jonas jonas commented Jul 6, 2017

Follow-up to aa84d85 to fix performance
regression noted in #649. Also cleans up open_prompt to not clear the
status window.

Follow-up to aa84d85 to fix performance
regression noted in #649. Also cleans up open_prompt to not clear the
status window.
@rolandwalker
Copy link
Contributor

This is nicer logic but doesn't address the performance regression in #649.

set_cursor_pos(0, 0) is the actual direct fix to the bug reported in #623. Readline is the problem. Ncurses fails to keep up with all the changes that may happen during readline world.

set_cursor_pos(0, 0) forces ncurses to sync some state, and it follows readline because that is the locus of the bug. getyx(newscr …) always returns incorrect values after Ctrl-C inside readline().

wclear() also forces ncurses to sync state, just expensively, because wclear() marks the entire screen dirty for redrawing. In this case we get a complete redraw on every keystroke.

@jonas jonas closed this Jul 6, 2017
@jonas jonas deleted the specialized-status-clear branch July 6, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants