Fix #232: Do not generate any input when handling Ctrl-Z #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the special case of Ctrl-Z introduced in 167d59e so no input is generated by get_input.
|
Seems reasonable, though the interplay here is difficult to work through. It is odd to think that #232 couldn't be solved if tig was still using |
|
It probably could have been solved, but I couldn't find a way to detect and flush the TTY input stream. You change to use raw mode made a fix more obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the special case of Ctrl-Z introduced in
167d59e so no input is generated by
get_input.
@rolandwalker does this seem reasonable to you?