Mirror fix #780
Merged
Mirror fix #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the file descriptor leak.
Fix the dead code. When reaching the line 45 in src/refdb.c, the condition "!tag_diff" must be true. This was a dead code. 42: if (tag_diff) 43: return tag_diff; 44: if (ref1->type != ref2->type) 45: return !tag_diff ? ref1->type - ref2->type : ref2->type - ref1->type;
sizeof(struct file_finder_line **) is equal to sizeof(struct file_finder_line *) now, but this is not a portable assumption. This assumption wil be wrong after struct file_finder_line is changed in the future. Use sizeof(*finder->line) instead of sizeof(finder->line).
jonas
reviewed
Feb 7, 2018
| @@ -42,7 +42,7 @@ ref_canonical_compare(const struct ref *ref1, const struct ref *ref2) | |||
| if (tag_diff) | |||
| return tag_diff; | |||
| if (ref1->type != ref2->type) | |||
| return !tag_diff ? ref1->type - ref2->type : ref2->type - ref1->type; | |||
| return (ref1->type - ref2->type); | |||
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.