Fix opening editor from diff-stat line #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for #781 This still doesn't fix the issue where the working directory gets set incorrectly when in a submodule.
|
Thanks a lot. It would be nice to have a test for this since sub modules are not “well” supported. I will try to find some time. |
|
See f99d2af for a related unit test (not in this branch for some reason). |
jonas
added a commit
that referenced
this pull request
May 20, 2018
|
Confirmed fixed. Thanks! |
rolandwalker
pushed a commit
to rolandwalker/tig
that referenced
this pull request
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #781
This still doesn't fix the underlying issue where the working directory gets set incorrectly when in a submodule.