Fix incorrect behaviour of up and down keys in diff view when opened from diff preview #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
reviewed
May 28, 2018
src/tig.c
Outdated
| @@ -235,7 +235,7 @@ view_driver(struct view *view, enum request request) | |||
|
|
|||
| case REQ_NEXT: | |||
| case REQ_PREVIOUS: | |||
| if (view->parent) { | |||
| if (view == display[1]) { | |||
| int line; | |||
|
|
|||
| view = view->parent; | |||
There was a problem hiding this comment.
Maybe view->parent && view == display [1] so this won't default.
|
Contextually speaking, I guess this makes more sense. I don't personally use the fullscreen navigation, but I remember doing it that way be because it felt more consistent at the time. |
…from diff preview Fixes jonas#802
|
I personally switch to full screen only when a commit requires extra attention and I always end up using the the arrow keys to navigate as there is not the commit list to remind me that up and down keys are bound to this list. I amended the PR to have view->parent && view == display [1]. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe issue #802 is the main reason why so many people ask about remapping up and down keys. If the current behaviour is actually a feature maybe a parameter can be introduced.