Fix error when trying to open diff view from split view on (Un)staged changes line #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing another usability issue Thomas. I've seen this but never got annoyed enough to investigate it further. |
jonas
added a commit
that referenced
this pull request
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occurs when you have staged or unstaged changes in the repository and is mostly visible when diff-highlight is true. If you press d or enter in the main view it will automatically switch to stage view while if you press d from the split view it opens diff view and you get an annoying "Failed run the diff-highlight program: diff-highlight". For consistency, switch to stage view as it is done for the main view when there is no commit associated to the selected line.