Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chrono::Duration #104

Merged
merged 3 commits into from
May 15, 2020
Merged

Add support for chrono::Duration #104

merged 3 commits into from
May 15, 2020

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented May 14, 2020

Part of #56

@jonasbb jonasbb force-pushed the chrono-duration branch 2 times, most recently from bfaf090 to 1fb4552 Compare May 15, 2020 07:35
@jonasbb jonasbb force-pushed the chrono-duration branch 2 times, most recently from 779aeb5 to 78b72f7 Compare May 15, 2020 19:02
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #104 into master will increase coverage by 1.79%.
The diff coverage is 91.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   77.75%   79.55%   +1.79%     
==========================================
  Files          23       23              
  Lines        1241     1423     +182     
==========================================
+ Hits          965     1132     +167     
- Misses        276      291      +15     
Impacted Files Coverage Δ
src/chrono.rs 73.93% <85.43%> (+19.10%) ⬆️
tests/chrono.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e776acb...78b72f7. Read the comment docs.

@jonasbb
Copy link
Owner Author

jonasbb commented May 15, 2020

bors r+

@bors bors bot merged commit f53efdc into master May 15, 2020
@bors bors bot deleted the chrono-duration branch May 15, 2020 22:04
@Stargateur
Copy link

Some doc would be nice

@jonasbb
Copy link
Owner Author

jonasbb commented Aug 7, 2020

I did not manage to document the new code sufficiently, but it is on my agenda. Contributions are welcome too :)

@jonasbb
Copy link
Owner Author

jonasbb commented Aug 14, 2020

@Stargateur I added some documentation for DurationSections and DurationSectionsWithFrac in #153. This is available in master now. I plan on putting out a new preview version soon too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants