Upstream merge #54
Open
Upstream merge #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, the calendar that gets used is undefined. With at least some CalDAV implementation this practically means one is randomly selected at every run. Having determinism at the small cost of required configuration is the user expected behaviour for anyone using an account with more than one calendar.
This commit attempts to address these two issues: Whenever calendar-cli is run on a clean new user account lacking a ~/.config directory, configuration is lost and has to be remade. There might be other cases for an Exception here and they are all annoying enough to warrant a change in behaviour. From a usability perspective, it is easy to be pressing enter a bit too quickly to stop at the save prompt. This is especially true if merely changing one or a couple of values while leaving the rest of them at their old value. Reasking to require an actual answer on what to do would be an improvement.
so the existing logic (choose the first calendar if none were specified) usually makes sense. Degrading the error to a warning for when there are several calendars and none is explicitly given.
Asking about calendar_url makes it easier to realize the correct format of caldav_url. Suggesting to read the documentation might help the more eager-to-get-started-souls (like e.g. me) to do it earlier.
Be consistent in using the selected timezone when outputing an agenda with a custom event template. Also rename first use of dtstart as search_dtstart and friends in calendar_agenda(), to reduce confusing reuse of same variable name for different purposes in same function.
…toxic conflict, moving to OFTC seems to be a reasonable neutral move.
Get password from a file
…ould probably fix the test script to report FAILED) when the tests fail). Timezones are difficult, indeed.
… file to an independent NEW_CLI.md
(I was working on this several months ago - then I got interrupted, forgot to commit, never got time to look back)
…more readable and modular ... but how?)
…all the stuff calendar-cli can do, plus more.
… weeks, but forgotten to commit
Minor cleanups to README.md
Minor cleanups to USER_GUIDE.md
…parate file - but I forgot to add the file
Allow 'location,' 'description,' and 'url' values to be used in template
…tation specific to calendar-cli
Separate calendar-cli repository from kal repository and make documen…
Correct SOME references to kal -> plann
`parse_timespec` function has been split out to `plann` and is no longer available.
Remove tests involving `parse_timespec`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.