Improve nonce_gen and fix sign_verify test vectors #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasnick
force-pushed
the
musig2-vectors-fix
branch
from
eaf2a83 to
8971392
Compare
real-or-random
added a commit
to BlockstreamResearch/secp256k1-zkp
that referenced
this pull request
Mar 2, 2023
b43dd83 musig: add missing static keyword to function (Jonas Nick) 068e6a0 musig: add test vectors from BIP MuSig (Jonas Nick) 36621d1 musig: update to BIP v1.0.0-rc.2 "Add ''pk'' arg to ''NonceGen''" (Jonas Nick) d717a49 musig: update to BIP v0.8 "Switch from X-only to plain pk inputs." (Jonas Nick) 304f1bc extrakeys: add pubkey_sort test vectors from BIP MuSig2 (Jonas Nick) ae89051 extrakeys: replace xonly_sort with pubkey_sort (Jonas Nick) 98242fc extrakeys: add secp256k1_pubkey_cmp (Jonas Nick) 73d5b66 musig: update to BIP v0.7.0 (NonceGen) (Jonas Nick) 060887e musig: update to BIP v0.5.1 "Rename ordinary tweaking to plain" (Jonas Nick) cbe2815 musig: update to BIP v0.4 "Allow the output of NonceAgg to be inf" (Jonas Nick) 206017d musig: update to BIP v0.3 (NonceGen) (Jonas Nick) d800dd5 musig: remove test vectors (Jonas Nick) Pull request description: Version 1.0.0-rc.3 of BIP MuSig2 can be found [here](jonasnick/bips#75). This PR does _not_ implement the following optional features that have been added to BIP MuSig2: - variable length messages - deterministic signing - identifiable aborts The PR also does _not_ yet change the `secnonce` structure to also contain the signer's public key (which would also imply changing the seckey argument in `sign` to a keypair). Additionally, we may want to rename some things in the future to be more consistent with the BIP (e.g. keyagg_cache vs. keyagg_ctx, applytweak vs. tweak_add). ACKs for top commit: ariard: Light Code Review ACK b43dd83, mostly looks on how the user API will make sense for Lightning, thanks for the answers! real-or-random: ACK b43dd83 Tree-SHA512: 9b1410951b55a1b0e6590b8c302052996d1fb6d9771765498b4282ff68b44ab0d6add8144c9330217b682ec5a93508b5546099db9a1f2c865f99253010dd76f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.