-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception in plugin Extra Icons #39
Comments
Thx. I was able to reproduce this error during integration tests, not with an actual IDE. Plugin tries to (re)load icons in a project that is being closed or is already closed. Up to IJ 2020.1, I fetched the list of opened projects to reload icons, but since IJ 2020.2 the API seems to return some closed or disposed project too. Will publish 1.37.1 release asap. |
Looks like it is back again
|
Just pulled a new version. Looks like the issue gone... |
issue is back on latest PHPStorm 2020.3.2 with plugin version 1.46.0.201
|
It's weird, this error is simply catched and logged at "debug" level. |
Yep, this stack trace appeared in the errors window, that popups up from the mentioned red icon. |
Thx @Spurlos Opened https://youtrack.jetbrains.com/issue/MP-3389 Also, I reintroduced a code that checks if project is disposed. I am not confident (it did not help in the past), it will probably do nothing, but can you make a try? Thx! |
Finally, found why these exceptions an thrown. See https://youtrack.jetbrains.com/issue/MP-3389#focus=Comments-27-4683999.0-0
Even if there is no exception, the logger creates an error badge for every error message. |
Just came to write here "Hallelujah!" and then I saw you reopened it again :( |
Added more checks. @Spurlos Can you make a try with this build? Extra Icons-1.46.0.201.zip |
haha yeah, github closed the issue because my commit message were mentioning this issue with the "fix" word XD |
Installed. Will reply if something popups |
Yesterday CLion said it has an update for this plugin. Installed it right away and since then it looks like the issue has gone. |
Thx! Will re-open if error occurs again. |
Latest CLion under Ubuntu 20.4
The text was updated successfully, but these errors were encountered: