Added custom sleep before we initiate shutdown #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mimic kubernetes preStop
mfld
approved these changes
Feb 1, 2021
xonvanetta
reviewed
Feb 2, 2021
| @@ -10,24 +10,41 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| func NewServerWithTimeout(t time.Duration) (*http.Server, chan struct{}) { | |||
| var testQuit chan os.Signal | |||
There was a problem hiding this comment.
Instead of this hack you could do something like this
https://github.com/xonvanetta/shutdown/blob/master/pkg/shutdown/shutdown_test.go#L38-L44
There was a problem hiding this comment.
I found this that i could be sent to the wrong thread so i did not want to use that.
golang/go#19326
perhaps not an issue in this case but...
xonvanetta
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mimic kubernetes preStop