You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Example: Retry custom behavior code snippet from the readme, it would be assumed that also passing in a retries: 3 would mean that there would be at-most 3 attempts of the function. However, it would appear that's not the case as I found from running this setup:
It's only after coming back to the docs and seeing the Example: Retry custom behaviour with async example which has an if check on the attempt number that I realised the initial retries property is then overridden by retryOn.
The text was updated successfully, but these errors were encountered:
This fixes the following:
* When we exceeded the max retries, we'd actually just keep retrying forever because `retryOn` overrode the `retries: 6` (see jonbern/fetch-retry#94)
* We have a fair amount of back off and no progress messages, so it appears like the CLI is just hanging even when it's still potentially making progress. I made it print quiet messages starting on the third retry so the CLI doesn't seem completely dead.
GitOrigin-RevId: 34db98eabc9e2df89b2569f6a07f8aaba41a6c72
This fixes the following:
* When we exceeded the max retries, we'd actually just keep retrying forever because `retryOn` overrode the `retries: 6` (see jonbern/fetch-retry#94)
* We have a fair amount of back off and no progress messages, so it appears like the CLI is just hanging even when it's still potentially making progress. I made it print quiet messages starting on the third retry so the CLI doesn't seem completely dead.
GitOrigin-RevId: 34db98eabc9e2df89b2569f6a07f8aaba41a6c72
In the
Example: Retry custom behavior
code snippet from the readme, it would be assumed that also passing in aretries: 3
would mean that there would be at-most 3 attempts of the function. However, it would appear that's not the case as I found from running this setup:It's only after coming back to the docs and seeing the
Example: Retry custom behaviour with async
example which has an if check on the attempt number that I realised the initialretries
property is then overridden byretryOn
.The text was updated successfully, but these errors were encountered: