Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #58

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix typo #58

merged 1 commit into from
Mar 8, 2023

Conversation

rockspore
Copy link
Contributor

No description provided.

@DPJacques
Copy link
Collaborator

Thanks for the fix. Sadly, I don't have permissions to merge it in :(

@rockspore
Copy link
Contributor Author

Thanks. I just wanted to get rid of the warning from my IDE :)

Is there no maintainer that regularly checks this repo? Also curious why you haven't been permitted the access to approve the workflow? ;-)

@DPJacques
Copy link
Collaborator

I have worked with @sagikazarmark to date. He has always been quite helpful. He is also more knowledgeable about Github workflows than I am.

I wasn't actively contributing to open source code until relatively recently.

sagikazarmark
sagikazarmark approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rockspore

@sagikazarmark sagikazarmark merged commit 040794b into jonboulle:master Mar 8, 2023
@rockspore rockspore deleted the typo branch March 8, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockspore @DPJacques @sagikazarmark