feat: add compute budget instructions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I would love to integrate these changes. I've updated everything to Zig 0.13, so everything should compile properly now once you rebase. Let me know when you want me to take a closer look. |
sonicfromnewyoke
force-pushed
the
sonic/compute-budget
branch
from
5fe7e96
to
ffc697e
Compare
joncinque
reviewed
Aug 30, 2024
src/compute_budget.zig
Outdated
| }, | ||
| /// Set a specific compute unit limit that the transaction is allowed to consume. | ||
| set_compute_unit_limit: struct { | ||
| units: u32, |
There was a problem hiding this comment.
nit: can this be renamed to compute_units for total clarity?
There was a problem hiding this comment.
renamed units -> compute_units
regarding avoiding allocations for program instructions, Ito not blowing up that thread I'd prefer to open the issue under the solana-program-sdk and describe a couple of possible allocation strategies:
create&destroy- comptime-based
- etc.
joncinque
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I understand your vision for that repository correctly, and compute_budget-related instructions should be located here.
Marking that MR as draft due to next reasons: