Fix accessing webkitBackingStorePixelRatio of context on iOS10 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jondavidjohn
requested changes
Sep 22, 2016
| @@ -1 +1,3 @@ | |||
| /node_modules | |||
| .idea | |||
There was a problem hiding this comment.
Not sure why we're adding .idea?
There was a problem hiding this comment.
Maybe this is something you could add to your system level .gitignore?
There was a problem hiding this comment.
.idea is a storage / config folder created by JetBrains' IDEs like WebStorm / PhpStorm. I added it as just in case if someone in future will also be using one of those IDEs.
I will remove it from PR.
On iOS 10 webkitBackingStorePixelRatio can be accessed only by using instance of CanvasRenderingContext2D. Using Object.create(prototype) in that case doesn't work so the only way to access that property is by getting context 2d from canvas element.
hinok
force-pushed
the
fix/iOS10-webkitBackingStorePixelRatio
branch
from
7a9cbfd to
7b212d5
Compare
|
I removed |
jondavidjohn
approved these changes
Sep 23, 2016
|
@hinok Thanks! Will get this released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS 10 webkitBackingStorePixelRatio can be accessed only by using
instance of CanvasRenderingContext2D. Using Object.create(prototype)
in that case doesn't work so the only way to access that property is by
getting context 2d from canvas element.