Serialization #46

jondo2010 · 2024-10-13T20:27:46Z

This is the first slice of #47, enabling serialization of the Env and ReactionGraph structs that get output from the builder stage.

Support for trait objects of user types is enabled through a type registry.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clippy

🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde`
  --> boomerang_runtime/src/reactor.rs:22:12
   |
22 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
   |            ^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste`
   = help: consider adding `serde` as a feature in `Cargo.toml`
   = note: see  for more information about checking conditional configuration

boomerang/boomerang_runtime/src/reactor.rs

Line 22 in 01c93de

#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]

🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde`
  --> boomerang_runtime/src/reactor.rs:27:16
   |
27 |     #[cfg_attr(feature = "serde", serde(skip))]
   |                ^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste`
   = help: consider adding `serde` as a feature in `Cargo.toml`
   = note: see  for more information about checking conditional configuration

boomerang/boomerang_runtime/src/reactor.rs

Line 27 in 01c93de

#[cfg_attr(feature = "serde", serde(skip))]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clippy

🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde`
  --> boomerang_runtime/src/reactor.rs:22:12
   |
22 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
   |            ^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste`
   = help: consider adding `serde` as a feature in `Cargo.toml`
   = note: see  for more information about checking conditional configuration

boomerang/boomerang_runtime/src/reactor.rs

Line 22 in 01c93de

#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]

🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde`
  --> boomerang_runtime/src/reactor.rs:27:16
   |
27 |     #[cfg_attr(feature = "serde", serde(skip))]
   |                ^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste`
   = help: consider adding `serde` as a feature in `Cargo.toml`
   = note: see  for more information about checking conditional configuration

boomerang/boomerang_runtime/src/reactor.rs

Line 27 in 01c93de

#[cfg_attr(feature = "serde", serde(skip))]

github-actions · 2024-10-23T06:50:39Z

boomerang_runtime/src/action/mod.rs


 /// Typed Action state, storing potentially different values at different Tags.
 #[derive(Debug)]
+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/action/mod.rs:19:12 | 19 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:39Z

boomerang_runtime/src/action/mod.rs

    pub store: Arc<Mutex<dyn BaseActionStore>>,
 }

+#[cfg(feature = "serde")]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/action/mod.rs:49:7 | 49 | #[cfg(feature = "serde")] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:39Z

boomerang_runtime/src/action/mod.rs

@@ -85,6 +113,7 @@ impl<'a> From<&'a mut Action> for &'a mut PhysicalAction {
 }

 #[derive(Debug)]
+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/action/mod.rs:116:12 | 116 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:39Z

boomerang_runtime/src/action/mod.rs

 pub struct PhysicalAction {
    pub name: String,
    pub key: ActionKey,
    pub min_delay: Duration,
+    #[cfg_attr(feature = "serde", serde(with = "serialize_physical_action_store"))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/action/mod.rs:45:16 | 45 | #[cfg_attr(feature = "serde", serde(with = "serialize_physical_action_store"))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:39Z

boomerang_runtime/src/action/store.rs

-where
-    T: ActionData,
-{
+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/action/store.rs:25:12 | 25 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:41Z

boomerang_runtime/src/reaction.rs

    }
 }

-impl<'store, F> ReactionFn<'store> for F
+#[cfg(feature = "serde")]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/reaction.rs:159:7 | 159 | #[cfg(feature = "serde")] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:41Z

boomerang_runtime/src/reaction.rs

@@ -115,34 +211,115 @@ impl Debug for Deadline {
    }
 }

+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/reaction.rs:214:12 | 214 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:41Z

boomerang_runtime/src/reaction.rs

 pub struct Reaction {
    name: String,
    /// Reaction closure
    pub(crate) body: BoxedReactionFn,
    /// Local deadline relative to the time stamp for invocation of the reaction.
+    #[cfg_attr(feature = "serde", serde(skip))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/reaction.rs:221:16 | 221 | #[cfg_attr(feature = "serde", serde(skip))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:41Z

boomerang_runtime/src/reactor.rs


-pub struct Reactor {
+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/reactor.rs:22:12 | 22 | #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

github-actions · 2024-10-23T06:50:41Z

boomerang_runtime/src/reactor.rs

    /// The reactor name
    name: String,
    /// The ReactorState
-    pub(crate) state: Box<dyn ReactorState>,
+    #[cfg_attr(feature = "serde", serde(skip))]


🚫 [clippy] _{reported by reviewdog 🐶}

error: unexpected `cfg` condition value: `serde` --> boomerang_runtime/src/reactor.rs:27:16 | 27 | #[cfg_attr(feature = "serde", serde(skip))] | ^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `erased-serde`, `linkme`, `parallel`, and `paste` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see for more information about checking conditional configuration

codecov · 2024-10-23T06:51:37Z

Codecov Report

Attention: Patch coverage is 68.73449% with 126 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (636ff7d) to head (fff46aa).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   77.30%   78.10%   +0.80%     
==========================================
  Files          48       47       -1     
  Lines        5930     5969      +39     
==========================================
+ Hits         4584     4662      +78     
+ Misses       1346     1307      -39

Components	Coverage Δ
boomerang	`100.00% <ø> (ø)`
boomerang_derive	`89.13% <100.00%> (+0.03%)`	⬆️
boomerang_runtime	`78.01% <61.82%> (-1.87%)`	⬇️
boomerang_tinymap	`88.13% <78.26%> (-1.15%)`	⬇️
boomerang_util	`26.92% <83.33%> (+16.14%)`	⬆️

jondo2010 added 6 commits October 10, 2024 09:28

WIP

5e0c3f4

WIP

90dd80c

Mostly finished Env serialization support

a1d6801

Fixed rest of tests

fd04e10

Move snake example into its own crate, fixup debug impls

83c4474

Unfuck

01c93de

github-actions bot reviewed Oct 22, 2024

View reviewed changes

jondo2010 added 3 commits October 22, 2024 22:39

fix

6619ba7

fix

c952d8a

fix

fff46aa

github-actions bot reviewed Oct 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialization #46

Serialization #46

jondo2010 commented Oct 13, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

github-actions bot Oct 23, 2024

codecov bot commented Oct 23, 2024


		pub struct Reactor {
		#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]

Serialization #46

Are you sure you want to change the base?

Serialization #46

Conversation

jondo2010 commented Oct 13, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot Oct 23, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 23, 2024

Codecov Report

jondo2010 commented Oct 13, 2024 •

edited

Loading