Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunOnce if refresh_interval is 0 #43

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

RunOnce if refresh_interval is 0 #43

wants to merge 14 commits into from

Conversation

boopathi
Copy link

No description provided.

@boopathi
Added - RunOnce if refresh_interval is 0
cfe95c2
@boopathi
Applying patch - drawAsInfitite
4575e01
@boopathi
Adding a script to compile the source code to a single minified JS code
201d01f
@boopathi
Adding execution permissions to the script - compile-source
17e9375
@boopathi
Directly access the coffeescript file rather than a manual compilatio…
41f3d88 
…n step
@boopathi
Fixed few bugs with compile source and cleaned up some code
3878139
@boopathi
Build index.js - stable
412d5be
@boopathi
jquery need not be imported any longer
9dda95d
@boopathi
Fixed bug - default param for asInfinite was set to First Metric
05b1094
@boopathi
Removing console.logs - UNCOMMENT when debugging
51fa447
@boopathi
Removing console.log - uncomment in graphene.coffee when debugging
6b65fd8
@boopathi
Improvement for drawAsInfinite - Use the label instead of index
cefb3d8
@boopathi
DrawAsInfinite now supports indexes and labels to choose from
721440a
@boopathi
Fix: Change script to its own directory so that it can be called from…
93fdf18 
… anywhere.
@jondot
Copy link
Owner

jondot commented Feb 1, 2013

Hi, thanks, looks like a lot of great work!
I wanted to ask a few questions -

  • How this pull relate to your other pull request (Draw as infinite #42)? should I do anything special before pulling it?
  • This is interesting, I've noticed you wrote your own build tool, did you have problems with the Guard based build system? do you prefer a different built system?
  • About logging - did you notice any performance implications because of too much logging?

I'm happy you find Graphene useful, and that you had the time to contribute, thanks! 👍 👍

@boopathi
Copy link
Author

boopathi commented Feb 5, 2013

  • I didn't want any special thing to be done. So committed the same code twice in those two different branches.
  • Just that I got used to Google closure compiler, thought I would add that as well, as an option.
  • Regarding logging, when used for production purposes, it becomes superfluous to the end users.

@jondot
Copy link
Owner

jondot commented Feb 18, 2013

Great, thanks. since I may have merge conflicts, I hope to over your commits go one by one and see which ones are still compatible. Hope to do that by end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boopathi @jondot