Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Flip specified drives in input histogram #905

Merged

Conversation

dylansdaniels
Copy link
Collaborator

@dylansdaniels dylansdaniels commented Oct 16, 2024

Adding functionality to specify spike types to invert when creating the input histogram.

So far:

image

Still need to test, etc. More coming soon :)

@dylansdaniels dylansdaniels requested a review from ntolley October 16, 2024 23:00
@dylansdaniels dylansdaniels self-assigned this Oct 16, 2024
@jasmainak
Copy link
Collaborator

can you add a tiny unit test to check that the inverted axis is indeed added?

hnn_core/viz.py Outdated Show resolved Hide resolved
@dylansdaniels dylansdaniels force-pushed the flip_evoked_input_hist branch from 53ff3c0 to 4b0010b Compare October 25, 2024 14:13
@dylansdaniels dylansdaniels changed the title [WIP] Flip specified drives in input histogram [MRG] Flip specified drives in input histogram Oct 25, 2024
@dylansdaniels
Copy link
Collaborator Author

@asoplata this should be ready for a final review!

@asoplata asoplata merged commit 95066ee into jonescompneurolab:master Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants