Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear_axis contextually removes second axis #929

Merged

Conversation

asoplata
Copy link
Collaborator

@asoplata asoplata commented Nov 7, 2024

This fixes a prior bug with my prior addition to _clear_axis where it would always remove the histogram's inverted second Axes object. It now only removes if it the desired Axes being cleared is a spike histogram.

@jasmainak
Copy link
Collaborator

@asoplata any chance we can add a unit test?

Copy link
Collaborator

@jasmainak jasmainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @ntolley merge button is yours

@asoplata asoplata merged commit c291a22 into jonescompneurolab:master Nov 7, 2024
12 checks passed
@asoplata asoplata deleted the hotfix-invert-axis-clear branch November 7, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants