-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azdevify chat sample #1
Conversation
Can you include information about why it fails to start? What are the symptoms? |
@@ -0,0 +1,127 @@ | |||
metadata description = 'Creates an Azure Function in an existing Azure App Service plan.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you copy this from latest? The latest is functions.bicep, not function.bicep, so I'm a little concerned that core wasn't copied from the latest. Can you double check all files are latest?
https://github.com/Azure/azure-dev/tree/main/templates/common/infra/bicep/core/host
@@ -0,0 +1,99 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use .bicepparam instead of mian.parameters.json
@@ -104,6 +104,96 @@ Out-of-the-box, you can upload the following file types: | |||
|
|||
![A screenshot of the chat app.](./media/chat-app.png) | |||
|
|||
## Develoy with Azure Developer CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check spelling and grammar
|
||
param identityName string | ||
param env array | ||
// param applicationInsightsName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out?
openAiName:openAiName | ||
appSettings: union(appSettings, { | ||
AzureWebJobsStorage: 'DefaultEndpointsProtocol=https;AccountName=${storage.name};AccountKey=${storage.listKeys().keys[0].value};EndpointSuffix=${environment().suffixes.storage}' | ||
// AZURE_BLOB_ACCOUNT_KEY : storage.listKey().keys[0].value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change /infra/core at all. It should be a clean copy and paste from the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments and update the bicep to match latest core and move app specific settings to /app. Thanks
param appServicePlanId string | ||
param keyVaultName string = '' | ||
param managedIdentity bool = !empty(keyVaultName) | ||
param AzureCognitiveSearch string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These settings shouldn't be in core, but in /app.
Please keep consistent casing. Camel for params.
@jongio We are currently investigating whether this chat sample uses
Which one do you think is appropriate? At present, after investigation, we think that Regarding the comments on this PRs, if we decide to use the |
Please follow what is here: https://github.com/jongio/chat-with-your-data-solution-accelerator/blob/main/infrastructure/deployment.bicep |
Azdevify this chat sample.
Finished:
Create the required resources with
/infra
, and the resources were successfully created. Runazd deploy
, the apps can be deployed normally.Questions:
Use
containerapp
to deploy, it cannot achieve complete interaction.Besides, we have tried use
appservice
to deploy apps, but the app startup failed.The relevant code is here: https://github.com/v-jiaodi/chat-with-your-data-solution-accelerator/tree/convert-azd-with-appservice
@jongio , @ruoccofabrizio and @gmndrg Do you have any ideas on these two issues?