fix output when note not found.

jonhadfield · Dec 18, 2023 · ca734eb · ca734eb
1 parent 7749887
commit ca734eb
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/cmd/sncli/note.go b/cmd/sncli/note.go
@@ -493,6 +493,12 @@ func outputNotes(c *cli.Context, count bool, output string, getNoteConfig sncli.
 	// strip deleted items
 	rawNotes = sncli.RemoveDeleted(rawNotes)
 
+	if len(rawNotes) == 0 {
+		_, _ = fmt.Fprintf(c.App.Writer, color.Green.Sprintf(msgNoMatches))
+
+		return nil
+	}
+
 	var numResults int
 
 	var notesYAML []sncli.NoteYAML

diff --git a/cmd/sncli/note_test.go b/cmd/sncli/note_test.go
@@ -31,6 +31,20 @@ func TestAddDeleteNote(t *testing.T) {
 	require.Contains(t, stdout, msgDeleted)
 }
 
+func TestGetMissingNote(t *testing.T) {
+	time.Sleep(1 * time.Second)
+	var outputBuffer bytes.Buffer
+	app, err := appSetup()
+	require.NoError(t, err)
+	app.Writer = &outputBuffer
+	osArgs := []string{"sncli", "get", "note", "--title", "missing note"}
+	err = app.Run(osArgs)
+	stdout := outputBuffer.String()
+	fmt.Println(stdout)
+	require.NoError(t, err)
+	require.Contains(t, stdout, msgNoMatches)
+}
+
 func TestDeleteNonExistantNote(t *testing.T) {
 	time.Sleep(1 * time.Second)
 	var outputBuffer bytes.Buffer