Avoid discarding capacity during read operation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
|
jonhoo
approved these changes
Feb 11, 2024
| return Poll::Ready(Err(io::Error::from(io::ErrorKind::BrokenPipe))); | ||
| match poll_reader(Pin::new(&mut self.reader), cx, &mut rest[..]) { | ||
| Poll::Ready(result) => { | ||
| let n = result?; |
There was a problem hiding this comment.
I wonder if we should also recover the capacity if we hit an Err here? It's less likely to matter than the (common) Pending case, but might as well just handle it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour caused the target buffer length to change between calls within a single read operation, which seems wrong since the underlying read would then try to read too much into a smaller buffer