Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Failure #89

Merged
merged 18 commits into from
Dec 31, 2024
Merged

Job Failure #89

merged 18 commits into from
Dec 31, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Nov 29, 2024

Addresses #88


This change is Reviewable

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.7%. Comparing base (cded093) to head (0576aba).
Report is 3 commits behind head on feature/mutate-api.

Files with missing lines Patch % Lines
src/worker/mod.rs 81.8% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/proto/mod.rs 72.7% <ø> (ø)
src/proto/single/mod.rs 99.2% <100.0%> (+2.1%) ⬆️
src/worker/mod.rs 84.0% <81.8%> (-1.1%) ⬇️

... and 3 files with indirect coverage changes

@rustworthy rustworthy requested a review from jonhoo December 27, 2024 13:21
@rustworthy rustworthy changed the title [WIP] Job Failure Job Failure Dec 27, 2024
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
@rustworthy rustworthy requested a review from jonhoo December 30, 2024 16:45
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving subject to the last two open threads which have easy fixes 👍

@rustworthy rustworthy merged commit 206e5f7 into feature/mutate-api Dec 31, 2024
19 checks passed
@rustworthy rustworthy deleted the feature/job-failure branch December 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants