Skip to content

Commit

Permalink
Ignore memory leaks from miri
Browse files Browse the repository at this point in the history 
These are probably spurious; see
crossbeam-rs/crossbeam#464
and
spacejam/sled#937 (comment)

And besides, we're now running both the leak sanitizer and the address
sanitizer.
  • Loading branch information
@jonhoo
jonhoo committed Jan 29, 2020
1 parent 953ddbd commit 7bd22c6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
rust: nightly
components:
- miri
- bash: yes | cargo miri test
- bash: yes | env RUSTFLAGS="-Zmiri-ignore-leaks" cargo miri test

This comment has been minimized.

Sign in to view

Copy link
@RalfJung

RalfJung Mar 17, 2020

Contributor

The recommended way to do this is cargo miri test -- -Zmiri-ignore-leaks. I am quite surprised using RUSTFLAGS even works.^^

Also, if you run cargo miri setup first, you shouldn't need yes | (see the README).

This comment has been minimized.

Sign in to view

Copy link
@jonhoo

jonhoo Mar 17, 2020

Author Owner

Yup, we already moved to that before landing this in CI, presumably because RUSTFLAGS didn't work :p

flurry/azure-pipelines.yml

Line 56 in 13db2fb

- bash: yes | cargo miri -Zmiri-ignore-leaks test

Thanks, I'll update with cargo miri setup and reference rust-lang/miri#940 in addition to crossbeam-rs/crossbeam#464 :)

This comment has been minimized.

Sign in to view

Copy link
@jonhoo

jonhoo Mar 17, 2020

Author Owner

Err, although miri is broken on current nightly 😅
displayName: cargo miri test
- job: asan
dependsOn: deny
Expand Down

0 comments on commit 7bd22c6

Please sign in to comment.