Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax Ord restriction on Deserialize #113

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

ian-p-cooke
Copy link
Contributor

@ian-p-cooke ian-p-cooke commented Feb 26, 2023

I needed to serialize a HashMap of f64 values and couldn't. I think the Ord bound is unnecessary.


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d7dd9b) 77.08% compared to head (960507d) 75.27%.
Report is 8 commits behind head on main.

❗ Current head 960507d differs from pull request most recent head c454ab1. Consider uploading reports for the commit c454ab1 to get more accurate results

Additional details and impacted files
Files Coverage Δ
src/serde_impls.rs 83.33% <ø> (+8.33%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this looks reasonable!

The Miri test failure appears to be unrelated. The format lint check is complaining correctly though — would you mind running your change through cargo fmt and update the PR?

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll land this and format it myself :)

@jonhoo jonhoo merged commit 25526a8 into jonhoo:main Feb 11, 2024
11 of 17 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Feb 11, 2024

Released in 0.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants