Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading hashbrown to 0.11.2? #17

Open
PsiACE opened this issue Apr 26, 2021 · 1 comment
Open

Consider upgrading hashbrown to 0.11.2? #17

PsiACE opened this issue Apr 26, 2021 · 1 comment

Comments

@PsiACE
Copy link
Contributor

PsiACE commented Apr 26, 2021

It seems that hashbrown 0.11.2 has quite a big change compared to 0.9.1. Will griddle consider following up?

@jonhoo
Copy link
Owner

jonhoo commented Apr 27, 2021

I think it would be worthwhile to update griddle to hashbrown 0.11, but unfortunately have limited time to do so myself since I'm not actively using griddle any longer. I'd be happy to help review a PR though!

In general the process should be straightforward — just diff each file in griddle against the corresponding file in hashbrown, and reconcile the differences (looking primarily at pub fns and pub types). For most diffs, it should be clear what has to happen. I would probably generally advise against introducing new methods unless their implementation is obvious — we can always add those later on in separate PRs.

There are a few changes I'd avoid for griddle in a version update PR:

  • The move to A: Allocator. That is something we should adopt eventually, but I'd keep that separate.
  • Anything related to DrainFilter.
  • Anything behind #[cfg(feature = "nightly")].

The raw module is the one that seems the most onerous because the implementation doesn't match up as nicely, but in most cases the griddle implementation just forwards to the hashbrown implementation with some extra bits here and there.

jonhoo pushed a commit that referenced this issue Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants