Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing APIs #4

Open
6 of 8 tasks
jonhoo opened this issue Jun 30, 2020 · 0 comments
Open
6 of 8 tasks

Implement missing APIs #4

jonhoo opened this issue Jun 30, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonhoo
Copy link
Owner

jonhoo commented Jun 30, 2020 •
edited
Loading

For the initial prototyping, a number of APIs were left out. These should be added back in (ordered roughly in order of difficulty):

  • Entry API\
    • OccupiedEntry::replace_*
  • serde and rayon support
  • RawEntry API
  • The Drain iterators
  • The reserve and shrink methods (and their siblings)
  • Support for the Extend trait
  • HashSet

In general, doing a diff between src/map.rs and hashbrown/src/map.rs should get you quite far. Remember to also add the corresponding tests!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonhoo