Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add simple pmc collapse to replace stackcollapse-pmc.pl. #214

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pbmtp
Copy link

@pbmtp pbmtp commented Jun 16, 2021

This is the start of a Rustification of stackcollapse-pmc.pl perl script.

DONE:

  • basic code (i am still learning Rust so feel free to suggest modification)
  • criterion bench
  • compare.sh (i need to do a pull request on brendangregg/FlameGraph for a little fix and optimization for stackcollapse-pmc.pl script)
  • guess code
  • regression tests (guess + pmc)

TODO:

  • implement kernel suffixing
  • filter raw function name (address)
  • symbol demangling (not done by pmcstat not for C++ nor for Rust)

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #214 (9c1945c) into master (9737ac7) will decrease coverage by 0.31%.
The diff coverage is 90.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   89.64%   89.33%   -0.32%     
==========================================
  Files          17       18       +1     
  Lines        2357     2485     +128     
==========================================
+ Hits         2113     2220     +107     
- Misses        244      265      +21     
Impacted Files Coverage Δ
src/collapse/mod.rs 52.63% <ø> (ø)
src/collapse/guess.rs 69.76% <80.00%> (+0.53%) ⬆️
src/collapse/pmc.rs 91.20% <91.20%> (ø)
src/collapse/vtune.rs 90.41% <0.00%> (-2.74%) ⬇️
src/collapse/sample.rs 88.88% <0.00%> (-2.03%) ⬇️
src/flamegraph/attrs.rs 90.62% <0.00%> (-1.05%) ⬇️
src/collapse/dtrace.rs 88.05% <0.00%> (-1.00%) ⬇️
src/collapse/perf.rs 95.07% <0.00%> (-0.38%) ⬇️
src/flamegraph/mod.rs 97.26% <0.00%> (-0.35%) ⬇️
src/collapse/common.rs 59.52% <0.00%> (-0.14%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9737ac7...9c1945c. Read the comment docs.

@jonhoo jonhoo marked this pull request as draft August 15, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant