Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #216

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Update dependencies #216

merged 2 commits into from
Sep 2, 2021

Conversation

djc
Copy link
Contributor

@djc djc commented Aug 31, 2021

While improving the flamegraph-rs repo setup I noticed that quite a few of inferno's dependencies are outdated. From quickly skimming the docs, I don't think any of these affect the public API, so this seems fairly straightforward.

The quick-xml upgrade changed the output for the test cases slightly
(omitting whitespace between the <script> tags and CDATA start/end),
so I solved that by updating the test data with nicer formatting.

I wrote a Python script to automatically rewrite test data for failing tests, I can submit that too if you like.

djc added 2 commits August 31, 2021 12:02
The quick-xml upgrade changed the output for the test cases slightly
(omitting whitespace between the <script> tags and CDATA start/end),
so I solved that by updating the test data with nicer formatting.
@djc
Copy link
Contributor Author

djc commented Aug 31, 2021

This turned out to require an MSRV bump. Given that the new MSRV is 1.46, which was released a year ago, that doesn't seem like a big deal?

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #216 (b7286df) into master (9737ac7) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   89.64%   89.26%   -0.39%     
==========================================
  Files          17       17              
  Lines        2357     2356       -1     
==========================================
- Hits         2113     2103      -10     
- Misses        244      253       +9     
Impacted Files Coverage Δ
src/flamegraph/svg.rs 97.69% <ø> (ø)
src/collapse/vtune.rs 90.41% <0.00%> (-2.74%) ⬇️
src/collapse/sample.rs 88.88% <0.00%> (-2.03%) ⬇️
src/flamegraph/attrs.rs 90.62% <0.00%> (-1.05%) ⬇️
src/collapse/dtrace.rs 88.05% <0.00%> (-1.00%) ⬇️
src/collapse/perf.rs 95.07% <0.00%> (-0.38%) ⬇️
src/flamegraph/mod.rs 97.26% <0.00%> (-0.35%) ⬇️
src/collapse/common.rs 59.52% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9737ac7...b7286df. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems entirely reasonable — thanks!

@jonhoo jonhoo merged commit 8516c57 into jonhoo:master Sep 2, 2021
@jonhoo
Copy link
Owner

jonhoo commented Sep 2, 2021

Published as 0.10.7 🎉

@djc
Copy link
Contributor Author

djc commented Sep 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants