-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping stack frames after a specified frame name #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 86.91% 87.01% +0.10%
==========================================
Files 17 17
Lines 2361 2380 +19
==========================================
+ Hits 2052 2071 +19
Misses 309 309
Continue to review full report at Codecov.
|
4e06955
to
877f9c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for stepping up to submit this! Left a few notes inline :)
5945bbe
to
da09009
Compare
it seems that clippy warnings are unrelated to this PR. |
btw, the clippy error should be fixed in |
Hi @jonhoo , could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks!
Released in 0.10.8 🎉 |
Fixes #221