-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port difffolded.pl as inferno-diff-folded #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 88.48% 89.02% +0.54%
==========================================
Files 11 12 +1
Lines 1294 1367 +73
==========================================
+ Hits 1145 1217 +72
- Misses 149 150 +1
Continue to review full report at Codecov.
|
I'm bothered enough about the sorting this PR adds to flamegraph that I think we should provide a way to opt out if you know the input is already sorted. We could make compatibility with upstream the default, but have a flag like |
@jasonrhansen I think something like |
I like the idea of detecting and warning about unsorted input when using |
Fixes #62
I also changed flamegraph to always sort input lines since the output of diff-folded isn't sorted. This matches the behavior of upstream flamegraph.