Support for HandshakeResponse320 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! Could you merge master into this so that you get the fixed CI and we can see how the tests fare? |
Upstream merge
|
Done :) |
jonhoo
approved these changes
Jul 5, 2020
flaneur2020
pushed a commit
to flaneur2020/msql-srv
that referenced
this pull request
Jan 12, 2022
…MORE Send ok packet after com field list
jonhoo
pushed a commit
that referenced
this pull request
Feb 3, 2024
Put 1.70 in there (for instance if you want to pin against OnceLock stabilizing) and it will actually test 1.7 as it appears github auto converts this to a float? Putting in quotes seems to do the right thing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First effort to fix #10.
It is not complete. But it parses everything that it should return from
clienthandshake().reference to mysql client handshake protocol.