Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BODYSTRUCTURE support #134

Closed
wants to merge 1 commit into from
Closed

Add BODYSTRUCTURE support #134

wants to merge 1 commit into from

Conversation

avitex
Copy link
Contributor

@avitex avitex commented Sep 2, 2019 •
edited by jonhoo
Loading

Exposes the body structure from a query.
Closes #116

This change is Reviewable

jonhoo
jonhoo requested changes Sep 2, 2019
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you please also include a test for it?

@avitex
Copy link
Contributor Author

avitex commented Sep 2, 2019

Sure can. Will add one to this branch tomorrow hopefully :)

@avitex
Copy link
Contributor Author

avitex commented Sep 3, 2019

@jonhoo At what level would you like a test placed?

@jonhoo
Copy link
Owner

jonhoo commented Sep 3, 2019

Unit tests in src/lib.rs are fine. Of course, integration tests would be great, but they're also much more of a pain to write, and this is a relatively small feature anyway :)

@jonhoo jonhoo mentioned this pull request Feb 24, 2020
Closed
@avitex
Copy link
Contributor Author

avitex commented Jun 18, 2020

Looks like this is already in now :)

@avitex avitex closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support BODYSTRUCTURE parsing for FETCH results
2 participants
@avitex @jonhoo