Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Feed video continues playing after opening post #460

Closed
geominorai opened this issue Sep 2, 2022 · 1 comment
Closed

[BUG] Feed video continues playing after opening post #460

geominorai opened this issue Sep 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@geominorai
Copy link

geominorai commented Sep 2, 2022 •
edited
Loading

Describe the bug

Videos played in the feed keep playing in the background after opening the post. Playing the video in the post also seems to put the feed's video player in an inconsistent state.

Ideally the feed video should automatically pause and if the opened post is the same as the video playing, it should skip to the timestamp it was at after opening.

To Reproduce
Steps to reproduce the behavior:

  1. Play a video on the feed
  2. Open any visible post while video is still playing
  3. See error

Screenshots

Fritter.mp4

The attached clip has sound to demonstrate the video playing in the background.

Device

Model: Samsung Galaxy S9+
OS: Android 10
Language: English
Fritter Version: v3.0.0-beta1
@geominorai geominorai added the bug Something isn't working label Sep 2, 2022
johann-gambol added a commit to johann-gambol/fritter that referenced this issue Sep 4, 2022
@johann-gambol
fix bug [jonjomckay#460] : videoplayer still playing in background
c3db950 
- wrap Chewie Player with VisbilityDetector from visibility_detector package [https://pub.dev/packages/visibility_detector]
jonjomckay added a commit that referenced this issue Sep 4, 2022
@johann-gambol @jonjomckay
fix bug [#460] : videoplayer still playing in background (#464)
a4b4862 
* fix bug [#460] : videoplayer still playing in background
- wrap Chewie Player with VisbilityDetector from visibility_detector package [https://pub.dev/packages/visibility_detector]

* - removed unused function

Co-authored-by: Jonjo McKay <jonjo@jonjomckay.com>
@geominorai
Copy link
Author

Fixed as of v3.0.0-beta3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geominorai