Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and Re-Added Feed, Tweet Search and Hashtag Search #698

Closed
wants to merge 5 commits into from
Closed

Fixed and Re-Added Feed, Tweet Search and Hashtag Search #698

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2023

I have fixed the Feed, Tweet Searching and Hashtag Searching. These features have been re-added and also fixed my own issue #668, #696 and #695. (As long as twitter don't disable their api again!)

APK File Upload

Github Release
Source Code

@Igaru22
Copy link

Igaru22 commented May 7, 2023

Thank you this version works great

@ghost
Copy link
Author

ghost commented May 7, 2023 via email

@ghost
Copy link

ghost commented May 7, 2023

Thank you so much for this great update! Fritter without a functioning feed is almost unusable. Don't wanna praise you too soon, but if it keeps working as flawless as it does at the moment, then you're truly a genius in my eyes!

@ghost
Copy link
Author

ghost commented May 7, 2023 via email

@Sponholz
Copy link

Sponholz commented May 7, 2023

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?

Fix was posted here: #690

@ghost
Copy link
Author

ghost commented May 7, 2023 via email

@Apacelus
Copy link

Apacelus commented May 7, 2023

I cant seem to be able to build this via the GitHub release workflow.

https://github.com/Apacelus/fritter/actions/runs/4908483128/jobs/8764272707

@ghost
Copy link
Author

ghost commented May 7, 2023 via email

@Apacelus
Copy link

Apacelus commented May 7, 2023

What OS are you using? Windows/Mac/Linux

On Sun, 7 May 2023, 18:50 Apacelus, @.> wrote: I cant seem to be able to build this via the GitHub release workflow. https://github.com/Apacelus/fritter/actions/runs/4908483128/jobs/8764272707 — Reply to this email directly, view it on GitHub <#698 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LE3TTNHMLHCJT7MR2LXE7OHNANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.>

Im using github workflows... I linked the run in my previous comment.
The run uses ubuntu-latest, so that would be ubuntu 22.04:
https://github.com/Apacelus/fritter/actions/runs/4908483128/workflow#L11

@ghost
Copy link
Author

ghost commented May 7, 2023

run

You cannot use github actions to build the app you have to use android studio!

@ghost
Copy link
Author

ghost commented May 7, 2023

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?

Fix was posted here: #690

I have now merged the pull request into my fork:
Github Release

@Apacelus
Copy link

Apacelus commented May 7, 2023

run

You cannot use github actions to build the app you have to use android studio!

The original project certainly used github actions to build their releases, so it is possible.

This reverts commit e82e58f.
@ghost
Copy link
Author

ghost commented May 7, 2023 via email

@Sponholz
Copy link

Sponholz commented May 7, 2023

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?
Fix was posted here: #690

I have now merged the pull request into my fork: Github Release

Thanks! Using it at the moment, really appreciate the time doing all the fixes.

Cheers!

@jonjomckay
Copy link
Owner

@TheHCJ thank you for putting in the effort to patch this - I really appreciate the support, but I won't be adding the feed back into Fritter. Please see my comment on issue #668.

@jonjomckay jonjomckay closed this May 8, 2023
@jaum20
Copy link

jaum20 commented May 9, 2023

I am late for the party. Repo deleted 🥲

@Sponholz
Copy link

Sponholz commented May 9, 2023

I am late for the party. Repo deleted 🥲

Check TheHCJ git page, he has now a fork of fritter with the feed.

I totally understand and respect Jonjomckay decision, but it's also nice to have an option with the feed included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants