Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup + New tests + User Verification #124

Merged
merged 9 commits into from
Apr 8, 2021
Merged

Cleanup + New tests + User Verification #124

merged 9 commits into from
Apr 8, 2021

Conversation

Jacoblab1
Copy link
Collaborator

This PR covers a few topics:

  • Cleaned up some code. There were instances where we were using tags to create links, so I modified them to be tags.
  • Added some integration tests
  • The "Add a question" and "Close Survey" buttons now check the current user cookie to verify that they have permission to do those actions.
  • Added the ability to copy a "Share this survey" link on the main survey view page.
  • Added a "Thank you for your response" template that shows after a user submits answers to a survey

@Jacoblab1 Jacoblab1 added the enhancement New feature or request label Apr 8, 2021
@Jacoblab1 Jacoblab1 self-assigned this Apr 8, 2021
pauliwag
pauliwag approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@pauliwag pauliwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pauliwag pauliwag merged commit d0f0d62 into main Apr 8, 2021
@jonmenard jonmenard linked an issue Apr 9, 2021 that may be closed by this pull request
Any user can close a survey, even if they do not own it #112
Closed
@Jacoblab1 Jacoblab1 mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauliwag pauliwag pauliwag approved these changes

Assignees

@Jacoblab1 Jacoblab1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any user can close a survey, even if they do not own it
2 participants
@Jacoblab1 @pauliwag